Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Modal image builder configuration by adding a specific builder version and adjusting the Python version. The changes ensure the Modal image uses a specific, stable image builder version.
Key Changes:
- Added explicit Modal image builder version (2025.10) using
.with_options() - Changed Python version from 3.13 to 3.12 for the Modal image
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| operating_sys = "ubuntu24.04" | ||
| tag = f"{cuda_version}-{flavor}-{operating_sys}" | ||
|
|
||
| # Move this to another file later: |
There was a problem hiding this comment.
The Python version has been changed from 3.13 to 3.12, which creates an inconsistency with the project's .python-version file that specifies 3.13. This could lead to confusion about which Python version should be used for development and deployment. If this change is necessary for compatibility with the Modal image builder version 2025.10, consider either updating the .python-version file to match or adding a comment explaining why the Modal image uses a different Python version.
| # Move this to another file later: | |
| # Move this to another file later: | |
| # NOTE: This image is pinned to Python 3.12 for compatibility with the Modal | |
| # image builder version 2025.10, even though the project .python-version | |
| # specifies Python 3.13. |
1 participant
In the web ui i also updated the runner to a newer image version of 2025 that way we can now use uv for installation which should make things a tiny bit faster